netdev
[Top] [All Lists]

Re: [PATCH] init_netdev missing locking

To: "Randy.Dunlap" <rddunlap@xxxxxxxxxxxxxxxx>
Subject: Re: [PATCH] init_netdev missing locking
From: "David S. Miller" <davem@xxxxxxxxxx>
Date: Wed, 15 Oct 2003 22:33:18 -0700
Cc: netdev@xxxxxxxxxxx
In-reply-to: <20031015110520.0206e327.rddunlap@xxxxxxxx>
References: <20031015110520.0206e327.rddunlap@xxxxxxxx>
Sender: netdev-bounce@xxxxxxxxxxx
On Wed, 15 Oct 2003 11:05:20 -0700
"Randy.Dunlap" <rddunlap@xxxxxxxx> wrote:

> It looks like the call to dev_alloc_name() in init_netdev()
> isn't protected by the required locking.
> This patch adds rtnl_lock/unlock around the call to dev_alloc_name().
> 
> Comments?  or please apply.

Your fix is correct, so I've applied it.  Stephen is working to
deprecate the one thing that uses this function (init_etherdev()).

Please in the future properly root your patch, I had to fix this
one up before my automated scripts would eat it :)

<Prev in Thread] Current Thread [Next in Thread>