| To: | Jeff Garzik <jgarzik@xxxxxxxxx> |
|---|---|
| Subject: | [PATCH] cosa -- incorrect comparison for register_netdev |
| From: | Stephen Hemminger <shemminger@xxxxxxxx> |
| Date: | Thu, 9 Oct 2003 11:27:14 -0700 |
| Cc: | netdev@xxxxxxxxxxx |
| Organization: | Open Source Development Lab |
| Sender: | netdev-bounce@xxxxxxxxxxx |
If register_netdev fails this driver will be in trouble because
the return values are things like -EIO or -EEXIST, not just -1.
diff -Nru a/drivers/net/wan/cosa.c b/drivers/net/wan/cosa.c
--- a/drivers/net/wan/cosa.c Thu Oct 9 11:24:39 2003
+++ b/drivers/net/wan/cosa.c Thu Oct 9 11:24:39 2003
@@ -615,7 +615,7 @@
d->get_stats = cosa_net_stats;
d->tx_timeout = cosa_sppp_timeout;
d->watchdog_timeo = TX_TIMEOUT;
- if (register_netdev(d) == -1) {
+ if (register_netdev(d)) {
printk(KERN_WARNING "%s: register_netdev failed.\n", d->name);
sppp_detach(chan->pppdev.dev);
free_netdev(chan->pppdev.dev);
|
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | [PATCH] 8139too.c Network interface messages, Krishnakumar. R |
|---|---|
| Next by Date: | Re: [PATCH] tun driver use private linked list., Max Krasnyansky |
| Previous by Thread: | [PATCH] 8139too.c Network interface messages, Krishnakumar. R |
| Next by Thread: | Re: [PATCH] cosa -- incorrect comparison for register_netdev, David S. Miller |
| Indexes: | [Date] [Thread] [Top] [All Lists] |