netdev
[Top] [All Lists]

Re: e1000 close (NAPI)

To: Robert Olsson <Robert.Olsson@xxxxxxxxxxx>
Subject: Re: e1000 close (NAPI)
From: "David S. Miller" <davem@xxxxxxxxxx>
Date: Wed, 8 Oct 2003 05:07:20 -0700
Cc: scott.feldman@xxxxxxxxx, Robert.Olsson@xxxxxxxxxxx, jgarzik@xxxxxxxxx, netdev@xxxxxxxxxxx
In-reply-to: <16259.54738.75122.134408@xxxxxxxxxxxx>
References: <C6F5CF431189FA4CBAEC9E7DD5441E0102229702@xxxxxxxxxxxxxxxxxxxxxx> <16259.54738.75122.134408@xxxxxxxxxxxx>
Sender: netdev-bounce@xxxxxxxxxxx
On Wed, 8 Oct 2003 11:16:02 +0200
Robert Olsson <Robert.Olsson@xxxxxxxxxxx> wrote:

> Feldman, Scott writes:
>  > > -        if(work_done < work_to_do) {
>  > > +        if(work_done < work_to_do || !netif_running(netdev)) {
>  > >                  netif_rx_complete(netdev);
>  > >                  e1000_irq_enable(adapter);
>  > >          }
>  > 
>  > Is e1000 unique in this regard, or do the other NAPI-enabled drivers
>  > have the same issue?
> 
>  Other drivers may have the same issue. This was spotted while stress-testing 
>  tulip. Patch was sent here some days ago. It's only seen if trying to close 
>  device under extreme loads. See the syncing code in dev_close()
> 
>  You may try the e100 as well. We update the docs when see that this is OK.

We should just fix all the NAPI drivers in this regard at one
time.  Undoubtedly tg3 needs this change too.

<Prev in Thread] Current Thread [Next in Thread>