| To: | "Feldman, Scott" <scott.feldman@xxxxxxxxx> |
|---|---|
| Subject: | RE: e1000 close (NAPI) |
| From: | Robert Olsson <Robert.Olsson@xxxxxxxxxxx> |
| Date: | Wed, 8 Oct 2003 11:16:02 +0200 |
| Cc: | "Robert Olsson" <Robert.Olsson@xxxxxxxxxxx>, "Jeff Garzik" <jgarzik@xxxxxxxxx>, <netdev@xxxxxxxxxxx> |
| In-reply-to: | <C6F5CF431189FA4CBAEC9E7DD5441E0102229702@xxxxxxxxxxxxxxxxxxxxxx> |
| References: | <C6F5CF431189FA4CBAEC9E7DD5441E0102229702@xxxxxxxxxxxxxxxxxxxxxx> |
| Sender: | netdev-bounce@xxxxxxxxxxx |
Feldman, Scott writes:
> > - if(work_done < work_to_do) {
> > + if(work_done < work_to_do || !netif_running(netdev)) {
> > netif_rx_complete(netdev);
> > e1000_irq_enable(adapter);
> > }
>
> Is e1000 unique in this regard, or do the other NAPI-enabled drivers
> have the same issue?
Hello!
Other drivers may have the same issue. This was spotted while stress-testing
tulip. Patch was sent here some days ago. It's only seen if trying to close
device under extreme loads. See the syncing code in dev_close()
You may try the e100 as well. We update the docs when see that this is OK.
Cheers.
--ro
|
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | [2.6 PATCH] ipvs - avoid returning NF_DROP from the packet schedulers, Julian Anastasov |
|---|---|
| Next by Date: | Re: [PATCH] Make SO_BINDTODEVICE bind very tightly, David S. Miller |
| Previous by Thread: | RE: e1000 close (NAPI), Feldman, Scott |
| Next by Thread: | Re: e1000 close (NAPI), David S. Miller |
| Indexes: | [Date] [Thread] [Top] [All Lists] |