| To: | Bart De Schuymer <bdschuym@xxxxxxxxxx> |
|---|---|
| Subject: | Re: [PATCH/RFC] Let {ip,arp}tables "see" bridged VLAN tagged {I,AR}P packets |
| From: | "David S. Miller" <davem@xxxxxxxxxx> |
| Date: | Tue, 7 Oct 2003 08:06:40 -0700 |
| Cc: | netdev@xxxxxxxxxxx, bridge@xxxxxxxx, greearb@xxxxxxxxxxxxxxx, vlan@xxxxxxxxxxx, shemminger@xxxxxxxx |
| In-reply-to: | <200310062204.07230.bdschuym@xxxxxxxxxx> |
| References: | <200310062204.07230.bdschuym@xxxxxxxxxx> |
| Sender: | netdev-bounce@xxxxxxxxxxx |
On Mon, 6 Oct 2003 22:04:07 +0200 Bart De Schuymer <bdschuym@xxxxxxxxxx> wrote: > - unsigned long hh[16 / sizeof(unsigned long)]; > + unsigned char hh[18]; Maybe don't do this? It should be aligned on a 'long' boundry I think. The only real hard objection I have with the patch is the vlan xmit routine pointer crap, just export the symbol. Once you fix that I'll apply your patch as long as Stephen has no objections. |
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | Re: [2.4 PATCH] two ipvs fixes, David S. Miller |
|---|---|
| Next by Date: | Re: [PATCH] spinlock badness in last dongle changes., David S. Miller |
| Previous by Thread: | Re: [Bridge] Re: [PATCH/RFC] Let {ip, arp}tables "see" bridged VLAN tagged {I, AR}P packets, Bart De Schuymer |
| Next by Thread: | Re: [Bridge] Re: [PATCH/RFC] Let {ip, arp}tables "see" bridged VLAN tagged {I,AR}P packets, Bart De Schuymer |
| Indexes: | [Date] [Thread] [Top] [All Lists] |