netdev
[Top] [All Lists]

Re: [irda-users] Re: [PATCH] (0/16) intro to IRDA patches for 2.6.0-test

To: Jean Tourrilhes <jt@xxxxxxxxxxxxxxxxxx>
Subject: Re: [irda-users] Re: [PATCH] (0/16) intro to IRDA patches for 2.6.0-test6
From: Martin Diehl <lists@xxxxxxxxx>
Date: Wed, 1 Oct 2003 01:25:34 +0200 (CEST)
Cc: Stephen Hemminger <shemminger@xxxxxxxx>, "David S. Miller" <davem@xxxxxxxxxx>, <netdev@xxxxxxxxxxx>, <irda-users@xxxxxxxxxxxxxxxxxxxxx>
In-reply-to: <20030930230049.GA22339@xxxxxxxxxxxxxxxxxx>
Sender: netdev-bounce@xxxxxxxxxxx
On Tue, 30 Sep 2003, Jean Tourrilhes wrote:

> On Tue, Sep 30, 2003 at 03:25:30PM -0700, Stephen Hemminger wrote:
> > These patches are a replacement for the moderate one chunk I sent out 
> > yesterday.
> > They continue in the same vein of revising how IRDA devices are allocated.
> > The new thing is the introduction of alloc_irdadev and changing over the 
> > places
> > I used alloc_netdev to that.
> > 
> > Mostly they are trivial, but smsc-ircc2 got changed to get rid of 
> > check_region
> > usage as well.
> > 
> > David, please apply after Jean gives his approval.
> 
>       The self destruct patch is absolutely needed, and I like very
> much the alloc_irdadev work.
>       Please go ahead, I'll test them in parallel.
>       Thanks !

I hadn't yet time for testing but since you were asking: I do also like 
the alloc_irdadev/free_netdev approach and the sir_dev part looks good to 
me, i.e. no leaking there. Thanks Stephen!

Martin


<Prev in Thread] Current Thread [Next in Thread>