netdev
[Top] [All Lists]

Re: RFC: [2.6 patch] disallow modular IPv6

To: Arnaldo Carvalho de Melo <acme@xxxxxxxxxxxxxxxx>
Subject: Re: RFC: [2.6 patch] disallow modular IPv6
From: David Woodhouse <dwmw2@xxxxxxxxxxxxx>
Date: Mon, 29 Sep 2003 10:02:55 +0100
Cc: Adrian Bunk <bunk@xxxxxxxxx>, netdev@xxxxxxxxxxx, davem@xxxxxxxxxx, pekkas@xxxxxxxxxx, lksctp-developers@xxxxxxxxxxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx
In-reply-to: <20030929003229.GM1039@xxxxxxxxxxxxxxxx>
References: <20030928225941.GW15338@xxxxxxxxx> <20030928231842.GE1039@xxxxxxxxxxxxxxxx> <20030928232403.GX15338@xxxxxxxxx> <20030928233909.GG1039@xxxxxxxxxxxxxxxx> <20030929001439.GY15338@xxxxxxxxx> <20030929003229.GM1039@xxxxxxxxxxxxxxxx>
Sender: netdev-bounce@xxxxxxxxxxx
On Sun, 2003-09-28 at 21:32 -0300, Arnaldo Carvalho de Melo wrote:
> Em Mon, Sep 29, 2003 at 02:14:39AM +0200, Adrian Bunk escreveu:
> > On Sun, Sep 28, 2003 at 08:39:10PM -0300, Arnaldo Carvalho de Melo wrote:
> > What about the following solution (the names and help texts for the
> > config options might not be optimal, I hope you understand the
> > intention):
> > 
> > config IPV6_SUPPORT
> >     bool "IPv6 support"
> > 
> > config IPV6_ENABLE
> >     tristate "enable IPv6"
> >     depends on IPV6_SUPPORT
> > 
> > IPV6_SUPPORT changes structs etc. and IPV6_ENABLE is responsible for 
> > ipv6.o .
> 
> Humm, and the idea is? This seems confusing, could you elaborate on why such
> scheme is a good thing?

The idea is that you then have ifdefs on CONFIG_IPV6_SUPPORT not on
CONFIG_IPV6_MODULE.

The underlying point being that your static kernel should not change if
you change an option from 'n' to 'm'. It should only affect the kernel
image if you change options to/from 'y'.

We should remove the definitions of 'CONFIG_xxxx_MODULE' entirely from
visibility during the build of non-module files, to prevent further
breakage of this sort.

-- 
dwmw2


<Prev in Thread] Current Thread [Next in Thread>