netdev
[Top] [All Lists]

[PATRCH] janitor: hermes: delete verify_area call

To: netdev@xxxxxxxxxxx
Subject: [PATRCH] janitor: hermes: delete verify_area call
From: "Randy.Dunlap" <rddunlap@xxxxxxxx>
Date: Thu, 25 Sep 2003 21:59:02 -0700
Cc: hermes@xxxxxxxxxxxxxxxxxxxxx, jgarzik@xxxxxxxxx
Organization: OSDL
Sender: netdev-bounce@xxxxxxxxxxx
Hi,
Please apply to 2.6.0-test5-current.

Thanks,
--
~Randy


From: Domen Puncer <domen@xxxxxxxxxxxx>

IMO, that verify_area wasn't needed.



 linux-260-t5bk12-kj-rddunlap/drivers/net/wireless/orinoco.c |    4 ----
 1 files changed, 4 deletions(-)

diff -puN drivers/net/wireless/orinoco.c~net_wireless_orinoco_verify 
drivers/net/wireless/orinoco.c
--- 
linux-260-t5bk12-kj/drivers/net/wireless/orinoco.c~net_wireless_orinoco_verify  
    2003-09-25 16:03:17.000000000 -0700
+++ linux-260-t5bk12-kj-rddunlap/drivers/net/wireless/orinoco.c 2003-09-25 
16:03:17.000000000 -0700
@@ -3833,10 +3833,6 @@ orinoco_ioctl(struct net_device *dev, st
                                { SIOCIWLASTPRIV, 0, 0, "dump_recs" },
                        };
 
-                       err = verify_area(VERIFY_WRITE, wrq->u.data.pointer, 
sizeof(privtab));
-                       if (err)
-                               break;
-                       
                        wrq->u.data.length = sizeof(privtab) / 
sizeof(privtab[0]);
                        if (copy_to_user(wrq->u.data.pointer, privtab, 
sizeof(privtab)))
                                err = -EFAULT;

_

<Prev in Thread] Current Thread [Next in Thread>