| To: | Christoph Hellwig <hch@xxxxxx> |
|---|---|
| Subject: | Re: skb_migrate() / net/atm/ipcommon.c |
| From: | chas williams <chas@xxxxxxxxxxxxxxxx> |
| Date: | Thu, 25 Sep 2003 09:17:21 -0400 |
| Cc: | netdev@xxxxxxxxxxx |
| In-reply-to: | Message from Christoph Hellwig <hch@xxxxxx> of "Thu, 25 Sep 2003 14:19:41 +0200." <20030925121941.GA409@xxxxxx> |
| Sender: | netdev-bounce@xxxxxxxxxxx |
>net/atm/ipcommon.c has a single function in it, skb_migrate which >looks pretty generic and his this comment ontop of it: > > * > * This function should live in skbuff.c or skbuff.h. > * > >So does this comment make sense, should it go into common code >(and kill the major ugliness in net/atm/Makefile :)) i am fairly sure this function will go away in the future. its used to move an existing skb_queue to a new queue, so the queue can be 're-processed'. it seems to me that it might be easier to just find the current tail of the queue and process the queue to that point instead of copying to a new list. its on that list of things to do. |
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | Re: [Patch]: IPv6 Connection Tracking, Yasuyuki Kozakai |
|---|---|
| Next by Date: | [PATCH][ATM]: [ioctl][1/8] move vcc_ioctl() to ioctl.c (from levon@xxxxxxxxxxxxxxxxx), chas williams |
| Previous by Thread: | skb_migrate() / net/atm/ipcommon.c, Christoph Hellwig |
| Next by Thread: | Re: skb_migrate() / net/atm/ipcommon.c, Mitchell Blank Jr |
| Indexes: | [Date] [Thread] [Top] [All Lists] |