Now that all the 2.4<->2.6 synchronizing stuff is done, we are moving
forward with the cleanup plan. This set is similar to the previous
set I sent on 8/27, but it is based on the latest version that was
accepted into the kernel with the seq_file changes, a few bug fixes
and a bit more cleanup stuff. This set is very comprehensive and
touches almost all the code. The set is broken down to many patches
for better tracking. It was already tested by me for functionality
and is undergoing a more thorough set of testing by our QA group for
any corner case bugs. A set that cleans up the 802.3ad code will
This patch applies on 2.4.23-pre5. It would also apply on 2.6.0 after
Amir's patch 2/10 from the "[bonding 2.6] propagating master's
settings to slaves" set is accepted by Jeff and applied on 2.6.
patch set can be downloaded from:
This will update the following files:
patch 1 - ifenslave lite - No more IP settings to slaves, unified
printing format, code re-org and broken to more functions.
patch 2 - convert all debug prints to use the dprintk macro and
consolidate format of all prints (e.g. "bonding: Error:
patch 3 - death of typedef. eliminate bonding_t/slave_t types and
patch 4 - remove dead code, old compatibility stuff and redundant
patch 5 - consolidate timers initialization, error checking and
patch 6 - convert too long if-else to a switch-case. Fix all locations
that handles bond->primary.
patch 7 - eliminate the multicast_mode module param. settings are now
done only according to mode.
patch 8 - slave list iteration - bond is no longer part of the list,
added cyclic list iteration macros.
patch 9 - consolidate function declarations:
o all functions begin with bond_
o return value, function name and all params are on the same
o change some function names to be more descriptive.
patch 10 - consolidate names of function params and variables (e.g.
bond_dev instead of dev/master/master_dev).
patch 11 - change names/types for some of the members in struct
bonding. change position of members.
patch 12 - consolidate return values of functions.
patch 13 - put curly braces around all if, else, for, while, switch
statements. change conditions to short format.
e.g. (ptr == NULL) ==> (!ptr)
patch 14 - consolidate error handling in all xmit functions.
patch 15 - chomp all trailing white space.
patch 16 - remove duplicate empty lines. add empty lines where needed
to improve readability.
patch 17 - fix indentations.
patch 18 - code re-organization in bond_main.c according to context
(e.g. module initialization, bond initialization, device
entry points, monitoring, etc.). some last minute minor
changes and fixes.
| Shmulik Hen Advanced Network Services |
| Israel Design Center, Jerusalem |
| LAN Access Division, Platform Networking |
| Intel Communications Group, Intel corp. |