netdev
[Top] [All Lists]

Re: ipt_physdev.c alignment problems on parisc64

To: "David S. Miller" <davem@xxxxxxxxxx>
Subject: Re: ipt_physdev.c alignment problems on parisc64
From: Bart De Schuymer <bdschuym@xxxxxxxxxx>
Date: Wed, 17 Sep 2003 08:42:17 +0200
Cc: tommy@xxxxxxxxxxxxxxxx, laforge@xxxxxxxxxxxxx, acme@xxxxxxxxxxxxxxxx, netfilter-devel@xxxxxxxxxxxxxxxxxxx, netdev@xxxxxxxxxxx
In-reply-to: <20030916182335.359c419f.davem@xxxxxxxxxx>
References: <200309022116.41697.bdschuym@xxxxxxxxxx> <200309161757.50682.bdschuym@xxxxxxxxxx> <20030916182335.359c419f.davem@xxxxxxxxxx>
Sender: netdev-bounce@xxxxxxxxxxx
User-agent: KMail/1.5
On Wednesday 17 September 2003 03:23, David S. Miller wrote:
> But recall that there are other netfilter modules doing this
> "compare chars using cast to long" trick that need to be fixed
> too.

Well, acme hasn't reported any other issues. Perhaps Rusty had foresight about 
these possible issues and made sure alignment was good...
In which case I don't see any reason for altering his code.

> Also, adding attributes to user exported structures would need
> to be done _very_ carefully, as compilation when using such
> gcc extensions will fail when the user uses '-ansi' on the
> compiler command line.

Now why on Earth would I have to bother with some luser doing this? I'm not 
the slave of annoying users.

cheers,
Bart


<Prev in Thread] Current Thread [Next in Thread>