netdev
[Top] [All Lists]

Re: [PATCH][ATM]: [clip] fix race between modifying entry->vccs and clip

To: Mitchell Blank Jr <mitch@xxxxxxxxxx>
Subject: Re: [PATCH][ATM]: [clip] fix race between modifying entry->vccs and clip_start_xmit()
From: "David S. Miller" <davem@xxxxxxxxxx>
Date: Mon, 15 Sep 2003 15:24:08 -0700
Cc: chas@xxxxxxxxxxxxxxxx, romieu@xxxxxxxxxxxxx, netdev@xxxxxxxxxxx
In-reply-to: <20030915223048.GD92642@xxxxxxxxxxxxxx>
References: <20030915225901.A22239@xxxxxxxxxxxxxxxxxxxxxxxxxx> <200309152159.h8FLx1Sa005910@xxxxxxxxxxxxxxxxxxxxxxx> <20030915150217.06b03168.davem@xxxxxxxxxx> <20030915223048.GD92642@xxxxxxxxxxxxxx>
Sender: netdev-bounce@xxxxxxxxxxx
On Mon, 15 Sep 2003 15:30:48 -0700
Mitchell Blank Jr <mitch@xxxxxxxxxx> wrote:

> David S. Miller wrote:
> > Are you really totally sure that no interrupt path can release
> > a VCC?
> 
> That should be the case at least for any VCC on a real interface[*].
> Some ATM cards have ->close() methods that can take a while so connection
> teardown has to happen with some sort of sleepable context.  So if there
> are cases where an interrupt causes the VCC to die they would need to be
> fixed anyways.

Ok, I'm convinced. :)

I'll apply Chas's patch then, thanks.

<Prev in Thread] Current Thread [Next in Thread>