| To: | linux-atm-general@xxxxxxxxxxxxxxxxxxxxx, netdev@xxxxxxxxxxx |
|---|---|
| Subject: | [PATCH] ATM - kill __free_atm_dev() |
| From: | John Levon <levon@xxxxxxxxxxxxxxxxx> |
| Date: | Fri, 5 Sep 2003 18:12:23 +0100 |
| Sender: | netdev-bounce@xxxxxxxxxxx |
| User-agent: | Mutt/1.3.25i |
Apply the "Levonov abstraction penalty" - the wrapping of kfree()
is pure obfuscation.
regards
john
diff -Naurp -X dontdiff linux-cvs/net/atm/resources.c
linux-fixes/net/atm/resources.c
--- linux-cvs/net/atm/resources.c 2003-06-23 23:08:56.000000000 +0100
+++ linux-fixes/net/atm/resources.c 2003-09-05 18:35:02.000000000 +0100
@@ -42,11 +42,6 @@ static struct atm_dev *__alloc_atm_dev(c
return dev;
}
-static void __free_atm_dev(struct atm_dev *dev)
-{
- kfree(dev);
-}
-
static struct atm_dev *__atm_dev_lookup(int number)
{
struct atm_dev *dev;
@@ -88,7 +83,7 @@ struct atm_dev *atm_dev_register(const c
if ((inuse = __atm_dev_lookup(number))) {
atm_dev_put(inuse);
spin_unlock(&atm_dev_lock);
- __free_atm_dev(dev);
+ kfree(dev);
return NULL;
}
dev->number = number;
@@ -119,7 +114,7 @@ struct atm_dev *atm_dev_register(const c
spin_lock(&atm_dev_lock);
list_del(&dev->dev_list);
spin_unlock(&atm_dev_lock);
- __free_atm_dev(dev);
+ kfree(dev);
return NULL;
}
}
@@ -154,7 +149,7 @@ void atm_dev_deregister(struct atm_dev *
}
}
- __free_atm_dev(dev);
+ kfree(dev);
}
void shutdown_atm_dev(struct atm_dev *dev)
|
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | Re: [PATCH 2.5.72] Red Creek VPN update, Francois Romieu |
|---|---|
| Next by Date: | Re: [Linux-ATM-General] [PATCH] ATM - fix seqfile compile failure, chas williams |
| Previous by Thread: | Fw: ksoftirqd causing severe network performance problems, Andrew Morton |
| Next by Thread: | Crash with e100 and ethtool on 2.6.0-test4 latest, Stephen Hemminger |
| Indexes: | [Date] [Thread] [Top] [All Lists] |