netdev
[Top] [All Lists]

Re: The recent free_netdev() conversion...

To: "David S. Miller" <davem@xxxxxxxxxx>
Subject: Re: The recent free_netdev() conversion...
From: Jeff Garzik <jgarzik@xxxxxxxxx>
Date: Mon, 01 Sep 2003 11:58:47 -0400
Cc: netdev@xxxxxxxxxxx
In-reply-to: <20030901075345.4c35e3e6.davem@xxxxxxxxxx>
Organization: none
References: <3F535EBD.6090401@xxxxxxxxx> <20030901075345.4c35e3e6.davem@xxxxxxxxxx>
Sender: netdev-bounce@xxxxxxxxxxx
User-agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.2.1) Gecko/20021213 Debian/1.2.1-2.bunk
David S. Miller wrote:
On Mon, 01 Sep 2003 10:59:09 -0400
Jeff Garzik <jgarzik@xxxxxxxxx> wrote:


    err_out:
        kfree(dev);

 ...

The "kfree" needs to be a free_netdev() too.


If the 'dev' hasn't been given to register_netdev() it
really doesn't need to be free_netdev().  It's just memory
until it has been given to the device layer.


True, but for long term, it's best to use free_netdev(). Besides naturally pairing with alloc_foodev(), if we ever decide to have alloc_netdev() perform more than one allocation, free_netdev() will already be in place to handle the multiple de-allocations.

        Jeff



<Prev in Thread] Current Thread [Next in Thread>