diff -Nur --exclude=RCS --exclude=CVS --exclude=SCCS --exclude=BitKeeper --exclude=ChangeSet linux-2.5.OLD/include/net/ipv6.h linux-2.5/include/net/ipv6.h --- linux-2.5.OLD/include/net/ipv6.h Mon Aug 18 10:04:07 2003 +++ linux-2.5/include/net/ipv6.h Fri Aug 15 13:29:00 2003 @@ -353,7 +353,9 @@ extern void ip6_flush_pending_frames(struct sock *sk); -extern struct dst_entry * ip6_dst_lookup(struct sock *sk, struct flowi *fl); +extern int ip6_dst_lookup(struct sock *sk, + struct dst_entry **dst, + struct flowi *fl); /* * skb processing functions diff -Nur --exclude=RCS --exclude=CVS --exclude=SCCS --exclude=BitKeeper --exclude=ChangeSet linux-2.5.OLD/net/ipv6/icmp.c linux-2.5/net/ipv6/icmp.c --- linux-2.5.OLD/net/ipv6/icmp.c Mon Aug 18 10:04:23 2003 +++ linux-2.5/net/ipv6/icmp.c Fri Aug 15 13:29:03 2003 @@ -355,8 +355,8 @@ if (!fl.oif && ipv6_addr_is_multicast(&fl.fl6_dst)) fl.oif = np->mcast_oif; - dst = ip6_dst_lookup(sk, &fl); - if (dst->error) goto out; + err = ip6_dst_lookup(sk, &dst, &fl); + if (err) goto out; if (hlimit < 0) { if (ipv6_addr_is_multicast(&fl.fl6_dst)) @@ -434,9 +434,9 @@ if (!fl.oif && ipv6_addr_is_multicast(&fl.fl6_dst)) fl.oif = np->mcast_oif; - dst = ip6_dst_lookup(sk, &fl); + err = ip6_dst_lookup(sk, &dst, &fl); - if (dst->error) goto out; + if (err) goto out; if (hlimit < 0) { if (ipv6_addr_is_multicast(&fl.fl6_dst)) diff -Nur --exclude=RCS --exclude=CVS --exclude=SCCS --exclude=BitKeeper --exclude=ChangeSet linux-2.5.OLD/net/ipv6/ip6_output.c linux-2.5/net/ipv6/ip6_output.c --- linux-2.5.OLD/net/ipv6/ip6_output.c Mon Aug 18 10:04:23 2003 +++ linux-2.5/net/ipv6/ip6_output.c Fri Aug 15 13:51:11 2003 @@ -1136,17 +1136,16 @@ return err; } -struct dst_entry *ip6_dst_lookup(struct sock *sk, struct flowi *fl) +int ip6_dst_lookup(struct sock *sk, struct dst_entry **dst, struct flowi *fl) { - struct dst_entry *dst = NULL; int err = 0; if (sk) { struct ipv6_pinfo *np = inet6_sk(sk); - dst = __sk_dst_check(sk, np->dst_cookie); - if (dst) { - struct rt6_info *rt = (struct rt6_info*)dst; + *dst = __sk_dst_check(sk, np->dst_cookie); + if (*dst) { + struct rt6_info *rt = (struct rt6_info*)*dst; /* Yes, checking route validity in not connected case is not very simple. Take into account, @@ -1170,39 +1169,38 @@ ipv6_addr_cmp(&fl->fl6_dst, &rt->rt6i_dst.addr)) && (np->daddr_cache == NULL || ipv6_addr_cmp(&fl->fl6_dst, np->daddr_cache))) - || (fl->oif && fl->oif != dst->dev->ifindex)) { - dst = NULL; + || (fl->oif && fl->oif != (*dst)->dev->ifindex)) { + *dst = NULL; } else - dst_hold(dst); + dst_hold(*dst); } } - if (dst == NULL) - dst = ip6_route_output(sk, fl); - - if (dst->error) - return dst; + if (*dst == NULL) + *dst = ip6_route_output(sk, fl); + if ((err = (*dst)->error)) { + dst_release(*dst); + return err; + } if (ipv6_addr_any(&fl->fl6_src)) { - err = ipv6_get_saddr(dst, &fl->fl6_dst, &fl->fl6_src); + err = ipv6_get_saddr(*dst, &fl->fl6_dst, &fl->fl6_src); if (err) { #if IP6_DEBUG >= 2 - printk(KERN_DEBUG "ip6_build_xmit: " + printk(KERN_DEBUG "ip6_dst_lookup: " "no available source address\n"); #endif - dst->error = err; - return dst; + dst_release(*dst); + return err; } } - - if (dst) { - if ((err = xfrm_lookup(&dst, fl, sk, 0)) < 0) { - dst->error = -ENETUNREACH; - } + if ((err = xfrm_lookup(dst, fl, sk, 0)) < 0) { + dst_release(*dst); + return -ENETUNREACH; } - return dst; + return 0; } int ip6_append_data(struct sock *sk, int getfrag(void *from, char *to, int offset, int len, int odd, struct sk_buff *skb), diff -Nur --exclude=RCS --exclude=CVS --exclude=SCCS --exclude=BitKeeper --exclude=ChangeSet linux-2.5.OLD/net/ipv6/raw.c linux-2.5/net/ipv6/raw.c --- linux-2.5.OLD/net/ipv6/raw.c Mon Aug 18 10:04:24 2003 +++ linux-2.5/net/ipv6/raw.c Fri Aug 15 13:33:14 2003 @@ -658,8 +658,8 @@ if (!fl.oif && ipv6_addr_is_multicast(&fl.fl6_dst)) fl.oif = np->mcast_oif; - dst = ip6_dst_lookup(sk, &fl); - if ((err = dst->error)) + err = ip6_dst_lookup(sk, &dst, &fl); + if (err) goto out; if (hlimit < 0) { diff -Nur --exclude=RCS --exclude=CVS --exclude=SCCS --exclude=BitKeeper --exclude=ChangeSet linux-2.5.OLD/net/ipv6/tcp_ipv6.c linux-2.5/net/ipv6/tcp_ipv6.c --- linux-2.5.OLD/net/ipv6/tcp_ipv6.c Mon Aug 18 10:04:24 2003 +++ linux-2.5/net/ipv6/tcp_ipv6.c Fri Aug 15 17:24:06 2003 @@ -663,19 +663,12 @@ ipv6_addr_copy(&fl.fl6_dst, rt0->addr); } - dst = ip6_dst_lookup(sk, &fl); + err = ip6_dst_lookup(sk, &dst, &fl); - if ((err = dst->error) != 0) { - dst_release(dst); + if (err) goto failure; - } if (saddr == NULL) { - err = ipv6_get_saddr(dst, &np->daddr, &fl.fl6_src); - if (err) { - dst_release(dst); - goto failure; - } saddr = &fl.fl6_src; ipv6_addr_copy(&np->rcv_saddr, saddr); } @@ -790,13 +783,14 @@ fl.fl_ip_dport = inet->dport; fl.fl_ip_sport = inet->sport; - dst = ip6_dst_lookup(sk, &fl); + if ((err = ip6_dst_lookup(sk, &dst, &fl))) { + sk->sk_err_soft = -err; + goto out; + } } else dst_hold(dst); - if (dst->error) { - sk->sk_err_soft = -dst->error; - } else if (tp->pmtu_cookie > dst_pmtu(dst)) { + if (tp->pmtu_cookie > dst_pmtu(dst)) { tcp_sync_mss(sk, dst_pmtu(dst)); tcp_simple_retransmit(sk); } /* else let the usual retransmit timer handle it */ @@ -891,8 +885,8 @@ ipv6_addr_copy(&fl.fl6_dst, rt0->addr); } - dst = ip6_dst_lookup(sk, &fl); - if (dst->error) + err = ip6_dst_lookup(sk, &dst, &fl); + if (err) goto done; } @@ -1020,9 +1014,7 @@ fl.fl_ip_sport = t1->source; /* sk = NULL, but it is safe for now. RST socket required. */ - buff->dst = ip6_dst_lookup(NULL, &fl); - - if (buff->dst->error == 0) { + if (!ip6_dst_lookup(NULL, &buff->dst, &fl)) { ip6_xmit(NULL, buff, &fl, NULL, 0); TCP_INC_STATS_BH(TcpOutSegs); TCP_INC_STATS_BH(TcpOutRsts); @@ -1083,9 +1075,7 @@ fl.fl_ip_dport = t1->dest; fl.fl_ip_sport = t1->source; - buff->dst = ip6_dst_lookup(NULL, &fl); - - if (buff->dst->error == 0) { + if (!ip6_dst_lookup(NULL, &buff->dst, &fl)) { ip6_xmit(NULL, buff, &fl, NULL, 0); TCP_INC_STATS_BH(TcpOutSegs); return; @@ -1331,11 +1321,9 @@ fl.fl_ip_dport = req->rmt_port; fl.fl_ip_sport = inet_sk(sk)->sport; - dst = ip6_dst_lookup(sk, &fl); - } - - if (dst->error) - goto out; + if (ip6_dst_lookup(sk, &dst, &fl)) + goto out; + } newsk = tcp_create_openreq_child(sk, req, skb); if (newsk == NULL) @@ -1730,11 +1718,9 @@ ipv6_addr_copy(&fl.fl6_dst, rt0->addr); } - dst = ip6_dst_lookup(sk, &fl); + err = ip6_dst_lookup(sk, &dst, &fl); - if (dst->error) { - err = dst->error; - dst_release(dst); + if (err) { sk->sk_route_caps = 0; return err; } @@ -1773,12 +1759,11 @@ dst = __sk_dst_check(sk, np->dst_cookie); if (dst == NULL) { - dst = ip6_dst_lookup(sk, &fl); + int err = ip6_dst_lookup(sk, &dst, &fl); - if (dst->error) { - sk->sk_err_soft = -dst->error; - dst_release(dst); - return -sk->sk_err_soft; + if (err) { + sk->sk_err_soft = -err; + return err; } ip6_dst_store(sk, dst, NULL); diff -Nur --exclude=RCS --exclude=CVS --exclude=SCCS --exclude=BitKeeper --exclude=ChangeSet linux-2.5.OLD/net/ipv6/udp.c linux-2.5/net/ipv6/udp.c --- linux-2.5.OLD/net/ipv6/udp.c Mon Aug 18 10:04:24 2003 +++ linux-2.5/net/ipv6/udp.c Fri Aug 15 13:34:28 2003 @@ -330,21 +330,11 @@ ipv6_addr_copy(&fl.fl6_dst, rt0->addr); } - dst = ip6_route_output(sk, &fl); - - if ((err = dst->error) != 0) { - dst_release(dst); + err = ip6_dst_lookup(sk, &dst, &fl); + if (err) goto out; - } - - /* get the source address used in the appropriate device */ - err = ipv6_get_saddr(dst, daddr, &fl.fl6_src); - - if (err) { - dst_release(dst); - goto out; - } + /* source address lookup done in ip6_dst_lookup */ if (ipv6_addr_any(&np->saddr)) ipv6_addr_copy(&np->saddr, &fl.fl6_src); @@ -930,8 +920,8 @@ if (!fl.oif && ipv6_addr_is_multicast(&fl.fl6_dst)) fl.oif = np->mcast_oif; - dst = ip6_dst_lookup(sk, &fl); - if ((err = dst->error)) + err = ip6_dst_lookup(sk, &dst, &fl); + if (err) goto out; if (hlimit < 0) {