netdev
[Top] [All Lists]

Re: [PATCH] Tigon3 driver update

To: "David S. Miller" <davem@xxxxxxxxxx>
Subject: Re: [PATCH] Tigon3 driver update
From: Jeff Garzik <jgarzik@xxxxxxxxx>
Date: Sun, 24 Aug 2003 02:05:00 -0400
Cc: linux-net@xxxxxxxxxxxxxxx, netdev@xxxxxxxxxxx
In-reply-to: <20030823214939.0c012f3d.davem@xxxxxxxxxx>
References: <20030823214939.0c012f3d.davem@xxxxxxxxxx>
Sender: netdev-bounce@xxxxxxxxxxx
User-agent: Mutt/1.3.28i
On Sat, Aug 23, 2003 at 09:49:39PM -0700, David S. Miller wrote:
> 
> Included is a Tigon3 driver test patch against current
> 2.6.0-testX kernels.
> 
> Features:
> 
> 1) Full 5705/5782/5788/5901 support.
> 2) More reliable PHY resetting on 5703/5704/5705.
> 3) Updated TSO support, it is not enabled by default
>    but one can turn it on using a current version of ethtool.
> 
> Feedback welcome.

Looks good, thanks.  One minor:

The tg3_[gs]et_tso code should be generic, like the tiny helpers at the
top of net/core/ethtool.c.  (well, tg3_get_tso is generic, and
tg3_set_tso could call the generic helper)

        Jeff




<Prev in Thread] Current Thread [Next in Thread>