Re: [PATCH] Change MAC without bringing interface down

[Arnaldo Carvalho de Melo <acme@xxxxxxxxxxxxxxxx>]

Em Mon, Aug 18, 2003 at 08:11:44PM +0300, Tommi Virtanen escreveu:
> +void neigh_changeaddr(struct neigh_table *tbl, struct net_device *dev)
> +{
> +     int i;
> +
> +     write_lock_bh(&tbl->lock);
> +
> +     for (i=0; i<=NEIGH_HASHMASK; i++) {


spaces before and after operators, please

> +struct notifier_block arp_netdev_notifier = {
> +     arp_netdev_event,
> +     NULL,
> +     0
> +};

c99 style please, that is:

struct notifier_block arp_netdev_notifier = {
        .notifier_call = arp_netdev_event,
}

> +struct notifier_block ndisc_netdev_notifier = {
> +     ndisc_netdev_event,
> +     NULL,
> +     0
> +};

ditto


Thanks,

- Arnaldo