netdev
[Top] [All Lists]

Re: [PATCH] Change MAC without bringing interface down

To: Tommi Virtanen <tv@xxxxxxxxxx>
Subject: Re: [PATCH] Change MAC without bringing interface down
From: Arnaldo Carvalho de Melo <acme@xxxxxxxxxxxxxxxx>
Date: Mon, 18 Aug 2003 15:51:53 -0300
Cc: "David S. Miller" <davem@xxxxxxxxxx>, hadi@xxxxxxxxxx, netdev@xxxxxxxxxxx
In-reply-to: <20030818171144.GC1793@lapdog>
Organization: Conectiva S.A.
References: <20030818091312.GA4889@lapdog> <20030818041911.358c3437.davem@xxxxxxxxxx> <1061208824.16010.2119.camel@xxxxxxxxxxxxxxxx> <20030818051227.4f35f2f3.davem@xxxxxxxxxx> <20030818160422.GB1793@lapdog> <20030818090654.7f44a16e.davem@xxxxxxxxxx> <20030818171144.GC1793@lapdog>
Sender: netdev-bounce@xxxxxxxxxxx
User-agent: Mutt/1.5.4i
Em Mon, Aug 18, 2003 at 08:11:44PM +0300, Tommi Virtanen escreveu:
> +void neigh_changeaddr(struct neigh_table *tbl, struct net_device *dev)
> +{
> +     int i;
> +
> +     write_lock_bh(&tbl->lock);
> +
> +     for (i=0; i<=NEIGH_HASHMASK; i++) {


spaces before and after operators, please

> +struct notifier_block arp_netdev_notifier = {
> +     arp_netdev_event,
> +     NULL,
> +     0
> +};

c99 style please, that is:

struct notifier_block arp_netdev_notifier = {
        .notifier_call = arp_netdev_event,
}

> +struct notifier_block ndisc_netdev_notifier = {
> +     ndisc_netdev_event,
> +     NULL,
> +     0
> +};

ditto


Thanks,

- Arnaldo

<Prev in Thread] Current Thread [Next in Thread>