Re: [PATCH] network device renaming sysfs fix

[Dan Aloni <da-x@xxxxxxx>]

On Sat, Aug 16, 2003 at 07:40:14AM -0700, David S. Miller wrote:
> On Fri, 15 Aug 2003 09:37:24 -0700
> Stephen Hemminger <shemminger@xxxxxxxx> wrote:
> 
> > The class_dev kobject name is 20 chars and IFNAMSIZ is 16, so the solution
> > needs to truncate if new_name is not null terminated (all 16 chars long).
> > 
> > This seems like the best approach:
> 
> Patch applied, thanks everyone.
> 
> Can't the device name also change via netlink messages?
> If so, do we handle that case properly?

No it can't, AFAIK. You might be confusing between netlink and 
notifier calls (which allow ipv4 to update the names of aliases
when the device name changes).

BTW, it is possible to add notifier handling for fixing device 
naming discrepancies regarding family-level sysctl registration. 
I think this is how the sysctl issue should be fixed.

-- 
Dan Aloni
da-x@xxxxxxx