Re: [PATCH] network device renaming sysfs fix

[Dan Aloni <da-x@xxxxxxx>]

On Fri, Aug 15, 2003 at 09:37:24AM -0700, Stephen Hemminger wrote:
> Yes, this is a better fix because it won't break when unregister and free are 
> split
> into seperate steps (coming soon).
> 
> But, do we really need the debug message?  
> Why return an error if you already committed the change? If you get an error,
> then don't rename the network device.
> 
> The class_dev kobject name is 20 chars and IFNAMSIZ is 16, so the solution
> needs to truncate if new_name is not null terminated (all 16 chars long).
> 
> This seems like the best approach:

Agreed.

> diff -Nru a/net/core/dev.c b/net/core/dev.c
> --- a/net/core/dev.c  Fri Aug 15 09:34:11 2003
> +++ b/net/core/dev.c  Fri Aug 15 09:34:11 2003
[patch]
-- 
Dan Aloni
da-x@xxxxxxx