netdev
[Top] [All Lists]

Re: [RFT][PATCH] cleanup net/atm/br2684.c

To: Stephen Hemminger <shemminger@xxxxxxxx>
Subject: Re: [RFT][PATCH] cleanup net/atm/br2684.c
From: Mitchell Blank Jr <mitch@xxxxxxxxxx>
Date: Tue, 12 Aug 2003 18:09:17 -0700
Cc: chas williams <chas@xxxxxxxxxxxxxxxx>, netdev@xxxxxxxxxxx
In-reply-to: <20030811153039.6df304fb.shemminger@xxxxxxxx>
References: <20030811114823.5b81474c.shemminger@xxxxxxxx> <20030811215857.GA96728@xxxxxxxxxxxxxx> <20030811153039.6df304fb.shemminger@xxxxxxxx>
Sender: netdev-bounce@xxxxxxxxxxx
User-agent: Mutt/1.4.1i
Stephen Hemminger wrote:
> > Mmmm.. I see this snippet in your diff in multiplce places and it looks
> > wrong.  Where does the "brdev" structure get freed now?
> > 
> The brdev structure is contained inside the allocation of net_device,
> this is how all the ether and other devices do it.

OK, sorry... that should have been obvious.  The reason I was confused is
that almost always the net_dev is referenced as brdev->net_dev which makes
look like brdev merely has a reference to net_dev.  I think it would be
cleaner to change the code to pass around "net_dev" instead of "brdev"
references (and just get the brdev via net_dev->priv as needed) and just
get rid of the brdev->net_dev pointer entirely.

Are you interested in doing that?  Otherwise I could take a crack at it
when I get the chance (I've done some surgery on this file before)

-Mitch

<Prev in Thread] Current Thread [Next in Thread>