| To: | "David S. Miller" <davem@xxxxxxxxxx> |
|---|---|
| Subject: | Re: PATCH: Add comment to make finding the priv_flags definition easier. |
| From: | Ben Greear <greearb@xxxxxxxxxxxxxxx> |
| Date: | Wed, 06 Aug 2003 10:30:18 -0700 |
| Cc: | netdev@xxxxxxxxxxx |
| In-reply-to: | <20030806034642.4d91641c.davem@xxxxxxxxxx> |
| Organization: | Candela Technologies |
| References: | <3F304AC7.6070808@xxxxxxxxxxxxxxx> <20030806034642.4d91641c.davem@xxxxxxxxxx> |
| Sender: | netdev-bounce@xxxxxxxxxxx |
| User-agent: | Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.5a) Gecko/20030718 |
David S. Miller wrote: On Tue, 05 Aug 2003 17:24:39 -0700 Ben Greear <greearb@xxxxxxxxxxxxxxx> wrote:This helps me, at least, remember where the definitions are at!This is silly, adding one for 'priv_flags' and not one for 'flags'. I really don't have a taste for these "look in file foo for interesting stuff about bar" type comments :-) Since they are not enums, it is hard to know where they are properly defined. For someone who is new to the code, I think it helps a great deal to say where the possible values are defined. I can add a comment for 'flags' as well, but not if no one cares anyway. Ben -- Ben Greear <greearb@xxxxxxxxxxxxxxx> Candela Technologies Inc http://www.candelatech.com |
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | Re: [PATCH] repairing rtcache killer, Robert Olsson |
|---|---|
| Next by Date: | Re: [PATCH] repairing rtcache killer, kuznet |
| Previous by Thread: | Re: PATCH: Add comment to make finding the priv_flags definition easier., David S. Miller |
| Next by Thread: | VLAN patch for 2.4.21, Ben Greear |
| Indexes: | [Date] [Thread] [Top] [All Lists] |