| To: | Jeff Garzik <jgarzik@xxxxxxxxx> |
|---|---|
| Subject: | Re: [PATCH] ethtool_ops rev 4 |
| From: | "David S. Miller" <davem@xxxxxxxxxx> |
| Date: | Sat, 2 Aug 2003 17:28:07 -0700 |
| Cc: | willy@xxxxxxxxxx, netdev@xxxxxxxxxxx |
| In-reply-to: | <3F2C3C86.6000202@xxxxxxxxx> |
| References: | <20030801150232.GV22222@xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx> <20030801154021.GA7696@xxxxxxx> <20030801154656.GW22222@xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx> <20030801162536.GA18574@xxxxxxx> <20030802222145.GE22222@xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx> <3F2C3C86.6000202@xxxxxxxxx> |
| Sender: | netdev-bounce@xxxxxxxxxxx |
On Sat, 02 Aug 2003 18:34:46 -0400
Jeff Garzik <jgarzik@xxxxxxxxx> wrote:
> Matthew Wilcox wrote:
> > +static inline void set_ethtool_ops(struct net_device *dev, struct
> > ethtool_ops *
> > ops)
> > +{
> > + dev->ethtool_ops = ops;
> > +}
>
>
> It needs to be a macro for maximum flexibility.
Yes, and please name it with capitol letters, ie.
SET_ETHTOOL_OPS(), I have no idea why you used
lower-case letters when Jeff and I referred to it
consistently with caps. :-)
|
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | Re: [PATCH] ethtool_ops rev 4, Jeff Garzik |
|---|---|
| Next by Date: | Re: [Linux-ATM-General] Re: [atmdrvr zatm] Remove obsolete EXACT_TS support, David S. Miller |
| Previous by Thread: | Re: [PATCH] ethtool_ops rev 4, Jeff Garzik |
| Next by Thread: | Re: [PATCH] ethtool_ops rev 4, Matthew Wilcox |
| Indexes: | [Date] [Thread] [Top] [All Lists] |