netdev
[Top] [All Lists]

RE: e100 "Ferguson" release

To: "Jeff Garzik" <jgarzik@xxxxxxxxx>
Subject: RE: e100 "Ferguson" release
From: "Feldman, Scott" <scott.feldman@xxxxxxxxx>
Date: Tue, 5 Aug 2003 07:28:58 -0700
Cc: <netdev@xxxxxxxxxxx>
Sender: netdev-bounce@xxxxxxxxxxx
Thread-index: AcNbEppm4ua1VvpURRC1DmNP6YxZrAASpVCA
Thread-topic: e100 "Ferguson" release
> > if(unlikely(e100_exec_cb(nic, skb, e100_xmit_prepare) == -ENOMEM)) {
> >         netif_stop_queue(netdev);
> >         nic->net_stats.tx_dropped++;
> >         dev_kfree_skb(skb);
> >         return 0;
> > }
> 
> Yes.  I would also printk(KERN_ERR "we have a bug!") or 
> somesuch, like several other drivers do, too.

It's there, sorry, was trying to keep the code snippet small.

> >>* (minor) use a netif_msg_xxx wrapper/constant in
> >>e100_init_module test?
> > 
> > 
> > Can't - don't have nic->msg_enable allocated yet.  :(
> 
> You could always use "(1 << debug) - 1"... :)  I dunno if it's worth 
> worrying about.

(1 << debug) - 1) & NETIF_MSG_DRV is what's there now.

-scott


<Prev in Thread] Current Thread [Next in Thread>