| To: | Krishna Kumar <krkumar@xxxxxxxxxx> |
|---|---|
| Subject: | Re: O/M flags against 2.6.0-test1 |
| From: | "David S. Miller" <davem@xxxxxxxxxx> |
| Date: | Wed, 23 Jul 2003 03:13:51 -0700 |
| Cc: | kuznet@xxxxxxxxxxxxx, yoshfuji@xxxxxxxxxxxxxx, netdev@xxxxxxxxxxx, linux-net@xxxxxxxxxxxxxxx, krkumar@xxxxxxxxxx |
| In-reply-to: | <Pine.LNX.4.44.0307221415140.14683-100000@xxxxxxxxxxxxxxxxxxxxxxxxxxx> |
| References: | <200307210155.FAA31320@xxxxxxxxxxxxx> <Pine.LNX.4.44.0307221415140.14683-100000@xxxxxxxxxxxxxxxxxxxxxxxxxxx> |
| Sender: | netdev-bounce@xxxxxxxxxxx |
On Tue, 22 Jul 2003 14:50:21 -0700 (PDT) Krishna Kumar <krkumar@xxxxxxxxxx> wrote: > I am using sizeof(struct xxx) or __u32, etc in the code, I guess you are > ok with that. This needs some fixes still. First thing, ipv6_devconf is not obtainable from user and has pointers in it which makes usage sloppy. So I would suggest the following: 1) Remove "void *sysctl;" from ipv6_devconf, move it into inet6_dev ie. "void *cnf_sysctl;" update all code users. 2) Move "struct ipv6_devconf" into some linux/*.h ipv6 header usable by users. Use an existing one if possible. Then make sure net/if_inet6.h includes this thing. 3) Change "int" members of struct "ipv6_devconf" to "s32". It's anal and unnecessary on any current platform, but some day with 128-bit computers it might make some difference. :-) Thanks. |
| Previous by Date: | Re: [PATCH] Prefix List against 2.4.21, David S. Miller |
|---|---|
| Next by Date: | Re: [Fwd: kernel 2.4.21], Cedric Gavage |
| Previous by Thread: | Re: O/M flags against 2.6.0-test1, Krishna Kumar |
| Next by Thread: | Re: O/M flags against 2.6.0-test1, Krishna Kumar |
| Indexes: | [Date] [Thread] [Top] [All Lists] |