[Top] [All Lists]

Re: netdev_ops?

To: Ben Greear <greearb@xxxxxxxxxxxxxxx>
Subject: Re: netdev_ops?
From: "David S. Miller" <davem@xxxxxxxxxx>
Date: Wed, 23 Jul 2003 01:15:51 -0700
Cc: netdev@xxxxxxxxxxx
In-reply-to: <3F1E4290.6020303@xxxxxxxxxxxxxxx>
References: <3F1E17BC.30100@xxxxxxxxxxxxxxx> <20030722220745.379a73c6.davem@xxxxxxxxxx> <3F1E1D62.90009@xxxxxxxxxxxxxxx> <20030722230215.284dd270.davem@xxxxxxxxxx> <3F1E2A00.5080506@xxxxxxxxxxxxxxx> <20030722232719.216d7823.davem@xxxxxxxxxx> <3F1E2CE9.2080404@xxxxxxxxxxxxxxx> <20030723000130.3a6a917e.davem@xxxxxxxxxx> <3F1E391B.80209@xxxxxxxxxxxxxxx> <20030723003439.684de751.davem@xxxxxxxxxx> <3F1E4290.6020303@xxxxxxxxxxxxxxx>
Sender: netdev-bounce@xxxxxxxxxxx
On Wed, 23 Jul 2003 01:08:48 -0700
Ben Greear <greearb@xxxxxxxxxxxxxxx> wrote:

> Is it their choice to participate in the /proc/net/dev output?

Precisely yes, this is why they have the option of not
providing the ->get_stats() method by leaving it set
to NULL.

> > My final note:  You don't even have the problem you claim to have.
> >                 Use your brain and 'grep' a little bit, ok? :-)
> > 
> >                 egrep get_stats net/core/rtnetlink.c
> > 
> >                 There it is, exactly what you need and supported on
> >                 every single kernel out there.
> Yep, I looked through that..and through libnetlink, and the complexity
> is not worth it.

Nice cop out.

Netlink is the standard method to obtain information about
network device, address, and route information.  It is even
defined by an RFC.

We're not going to add a hack to the kernel just because you
think netlink is too complex.  If it's too complex, you get
to live with the text based output.

I'll tell you this, the netlink version will work on more systems,
even ones that don't have /proc mounted.

Your patch duplicates existing functionality (getting network
statistics in binary form), so just based upon that I cannot allow
your patch.

<Prev in Thread] Current Thread [Next in Thread>