netdev
[Top] [All Lists]

Re: [PATCH - RFC] [1/2] 2.6 must-fix list - kernel error reporting

To: Jim Keniston <jkenisto@xxxxxxxxxx>
Subject: Re: [PATCH - RFC] [1/2] 2.6 must-fix list - kernel error reporting
From: James Morris <jmorris@xxxxxxxxxxxxxxxx>
Date: Thu, 10 Jul 2003 14:42:44 +1000 (EST)
Cc: LKML <linux-kernel@xxxxxxxxxxxxxxx>, <netdev@xxxxxxxxxxx>, Andrew Morton <akpm@xxxxxxxx>, "David S. Miller" <davem@xxxxxxxxxx>, Jeff Garzik <jgarzik@xxxxxxxxx>, Alan Cox <alan@xxxxxxxxxxxxxxxxxxx>, Randy Dunlap <rddunlap@xxxxxxxx>
In-reply-to: <3F0AFFE6.E85FF283@xxxxxxxxxx>
Sender: netdev-bounce@xxxxxxxxxxx
On Tue, 8 Jul 2003, Jim Keniston wrote:

+       kerror_nl = netlink_kernel_create(NETLINK_KERROR, kerror_netlink_rcv);
+       if (kerror_nl == NULL)
+               panic("kerror_init: cannot initialize kerror_nl\n");

You can simply use NULL instead of passing the dummy kerror_netlink_rcv
function.

+struct kern_log_entry {
+       __u16   log_kmagic;     /* always LOGREC_KMAGIC */
+       __u16   log_kversion;   /* which version of this struct? */
+       char    log_facility[FACILITY_MAXLEN];  /* e.g., driver name */

These fields should generally be specified in ascending order to help with 
alignment.

It may also be worth looking at how the ULOG code batches messages to 
improve peformance.




- James
-- 
James Morris
<jmorris@xxxxxxxxxxxxxxxx>





<Prev in Thread] Current Thread [Next in Thread>