| To: | Andi Kleen <ak@xxxxxxx> |
|---|---|
| Subject: | Re: reasons for dev_alloc_skb +16? |
| From: | Jeff Garzik <jgarzik@xxxxxxxxx> |
| Date: | Wed, 9 Jul 2003 12:06:57 -0400 |
| Cc: | netdev@xxxxxxxxxxx |
| In-reply-to: | <20030709175355.422545b5.ak@xxxxxxx> |
| References: | <20030709152553.GB15293@xxxxxxx> <20030709175355.422545b5.ak@xxxxxxx> |
| Sender: | netdev-bounce@xxxxxxxxxxx |
| User-agent: | Mutt/1.3.28i |
On Wed, Jul 09, 2003 at 05:53:55PM +0200, Andi Kleen wrote:
> On Wed, 9 Jul 2003 11:25:53 -0400
> Jeff Garzik <jgarzik@xxxxxxxxx> wrote:
>
> > I knew this at one time, but have forgotten it :)
> >
> > What is the reason for adding 16 to the dev_alloc_skb length?
> > (and skb_reserve of the same length)
>
> For the skb_reserve alignment to align the IP header.
>
> But it's not clear it is still a good idea because it leads to cache line
> misalignment of the beginning of the packet, forcing the card to do a
> costly Read-Modify-Write cycle.
Exactly. Ben H is running into this, and pondering direct use of
alloc_skb for precisely this reason.
Jeff
|
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | Re: reasons for dev_alloc_skb +16?, Andi Kleen |
|---|---|
| Next by Date: | Re: reasons for dev_alloc_skb +16?, Andi Kleen |
| Previous by Thread: | Re: reasons for dev_alloc_skb +16?, Andi Kleen |
| Next by Thread: | Re: reasons for dev_alloc_skb +16?, Andi Kleen |
| Indexes: | [Date] [Thread] [Top] [All Lists] |