netdev
[Top] [All Lists]

Re: [PATCH] netdev_ops

To: Ben Greear <greearb@xxxxxxxxxxxxxxx>
Subject: Re: [PATCH] netdev_ops
From: Matthew Wilcox <willy@xxxxxxxxxx>
Date: Tue, 8 Jul 2003 22:25:51 +0100
Cc: Matthew Wilcox <willy@xxxxxxxxxx>, netdev@xxxxxxxxxxx
In-reply-to: <3F0B2D30.4020102@xxxxxxxxxxxxxxx>
References: <20030708163042.GL23597@xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx> <3F0B2D30.4020102@xxxxxxxxxxxxxxx>
Sender: netdev-bounce@xxxxxxxxxxx
User-agent: Mutt/1.4.1i
On Tue, Jul 08, 2003 at 01:44:32PM -0700, Ben Greear wrote:
> Some of these are missing their netdevice arg?
> >+    int     (*get_regs_len)(struct ethtool_regs *);
> >+    int     (*self_test_len)(struct ethtool_test *);
> >+    int     (*get_strings_len)(struct ethtool_gstrings *);
> >+    int     (*get_stats_len)(struct ethtool_stats *);

Well, they don't actually need it -- these are more attributes of
the underlying driver than they are of any individual network device.
I suspect at least one of them isn't needed, and I'm sure the e1000 guys
are about to tell me which one ;-)

-- 
"It's not Hollywood.  War is real, war is primarily not about defeat or
victory, it is about death.  I've seen thousands and thousands of dead bodies.
Do you think I want to have an academic debate on this subject?" -- Robert Fisk

<Prev in Thread] Current Thread [Next in Thread>