netdev
[Top] [All Lists]

Re: [PATCH] IPV6: use macro for M-Flag and clean-up

To: jmorris@xxxxxxxxxxxxxxxx
Subject: Re: [PATCH] IPV6: use macro for M-Flag and clean-up
From: YOSHIFUJI Hideaki / 吉藤英明 <yoshfuji@xxxxxxxxxxxxxx>
Date: Sun, 29 Jun 2003 11:25:44 +0900 (JST)
Cc: davem@xxxxxxxxxx, netdev@xxxxxxxxxxx
In-reply-to: <Mutt.LNX.4.44.0306291114120.20809-100000@xxxxxxxxxxxxxxxxxxxxxxxxxx>
Organization: USAGI Project
References: <20030628.203011.05536524.yoshfuji@xxxxxxxxxxxxxx> <Mutt.LNX.4.44.0306291114120.20809-100000@xxxxxxxxxxxxxxxxxxxxxxxxxx>
Sender: netdev-bounce@xxxxxxxxxxx
In article 
<Mutt.LNX.4.44.0306291114120.20809-100000@xxxxxxxxxxxxxxxxxxxxxxxxxx> (at Sun, 
29 Jun 2003 11:14:35 +1000 (EST)), James Morris <jmorris@xxxxxxxxxxxxxxxx> says:

> On Sat, 28 Jun 2003, YOSHIFUJI Hideaki / [iso-2022-jp] 吉藤英明 wrote:
> 
> > -           fh->frag_off = htons(0x0001);
> > +           fh->frag_off = htons(IP6_MF);
> 
> Please use __constant_htons().

No. We don't use __constant_hton{s,l} in runtime code
since October, 2002.  We use hton{s,l} when we can.

-- 
Hideaki YOSHIFUJI @ USAGI Project <yoshfuji@xxxxxxxxxxxxxx>
GPG FP: 9022 65EB 1ECF 3AD1 0BDF  80D8 4807 F894 E062 0EEA

<Prev in Thread] Current Thread [Next in Thread>