Re: [PATCH] Convert pppoe to new style protocol

[Andi Kleen <ak@xxxxxxx>]

On Tue, Jun 17, 2003 at 03:07:51PM -0700, David S. Miller wrote:
>    From: Andi Kleen <ak@xxxxxx>
>    Date: Wed, 18 Jun 2003 00:04:20 +0200
> 
>    Convert pppoe to a new style protocol, otherwise it is unusable 
>    on SMP compiled kernels because of the printk in deliver*old_ones.
>    It works fine here, but only tested on a UP box.
> 
> Please don't add new skb_linearize() users, I'm trying
> to make that only local to net/core/dev.c

Then offer a flag or something for protocols that also doesn't trigger
printks ?


> 
> Otherwise I'm fine with your patch.

How else should it be done? 

I'm not going through the whole PPP layer now to audit it for non linear
skb cleanliness...

-Andi