| To: | "David S. Miller" <davem@xxxxxxxxxx> |
|---|---|
| Subject: | Re: patch for common networking error messages |
| From: | Janice Girouard <girouard@xxxxxxxxxx> |
| Date: | Mon, 16 Jun 2003 17:29:15 -0500 |
| Cc: | Daniel Stekloff <stekloff@xxxxxxxxxx>, janiceg@xxxxxxxxxx, jgarzik@xxxxxxxxx, kenistonj@xxxxxxxxxx, Larry Kessler <lkessler@xxxxxxxxxx>, linux-kernel@xxxxxxxxxxxxxxx, netdev@xxxxxxxxxxx, niv@xxxxxxxxxx, <niv@xxxxxxxxxx> |
| Sender: | netdev-bounce@xxxxxxxxxxx |
From: "David S. Miller" <davem@xxxxxxxxxx>
Date : 06/16/2003 05:13 PM
egrep "promiscuous mode" net/core/dev.c | grep printk
I noticed when I performed the grep, the printk shows:
printk(KERN_INFO "device %s %s promiscuous mode\n"
For the sake of consistency and automatic error log analysis, it might be
nice to standardize on a message closer to:
printk(KERN_INFO "%s: %s promiscuous mode\n"
It's somewhat common, but not universal to start the error message with the
device name followed by a colon.
Janice
|
| Previous by Date: | Re: patch for common networking error messages, David S. Miller |
|---|---|
| Next by Date: | Re: patch for common networking error messages, David S. Miller |
| Previous by Thread: | Re: patch for common networking error messages, Donald Becker |
| Next by Thread: | Re: patch for common networking error messages, David S. Miller |
| Indexes: | [Date] [Thread] [Top] [All Lists] |