netdev
[Top] [All Lists]

Re: patch for common networking error messages

To: "David S. Miller" <davem@xxxxxxxxxx>
Subject: Re: patch for common networking error messages
From: Andi Kleen <ak@xxxxxxx>
Date: Mon, 16 Jun 2003 22:53:42 +0200
Cc: janiceg@xxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, netdev@xxxxxxxxxxx, stekloff@xxxxxxxxxx, girouard@xxxxxxxxxx, lkessler@xxxxxxxxxx, kenistonj@xxxxxxxxxx, jgarzik@xxxxxxxxx
In-reply-to: <20030616.133841.35533284.davem@xxxxxxxxxx>
References: <3EEE28DE.6040808@xxxxxxxxxx> <20030616.133841.35533284.davem@xxxxxxxxxx>
Sender: netdev-bounce@xxxxxxxxxxx
On Mon, Jun 16, 2003 at 01:38:41PM -0700, David S. Miller wrote:
>    From: Janice M Girouard <janiceg@xxxxxxxxxx>
>    Date: Mon, 16 Jun 2003 15:30:22 -0500
> 
>    EMSG_NET_LINK_UP     "%s: state change: link up, %d Mbps, %s-duplex\n"
> 
> Should indicate flow control state too.

It would be actually useful  to wrap these in real functions.

Why? It will make supporting netconsole easier which has to be careful
to never recurse in the network driver.

-Andi


<Prev in Thread] Current Thread [Next in Thread>