netdev
[Top] [All Lists]

Re: patch for common networking error messages

To: janiceg@xxxxxxxxxx
Subject: Re: patch for common networking error messages
From: "David S. Miller" <davem@xxxxxxxxxx>
Date: Mon, 16 Jun 2003 13:38:41 -0700 (PDT)
Cc: linux-kernel@xxxxxxxxxxxxxxx, netdev@xxxxxxxxxxx, stekloff@xxxxxxxxxx, girouard@xxxxxxxxxx, lkessler@xxxxxxxxxx, kenistonj@xxxxxxxxxx, jgarzik@xxxxxxxxx
In-reply-to: <3EEE28DE.6040808@xxxxxxxxxx>
References: <3EEE28DE.6040808@xxxxxxxxxx>
Sender: netdev-bounce@xxxxxxxxxxx
   From: Janice M Girouard <janiceg@xxxxxxxxxx>
   Date: Mon, 16 Jun 2003 15:30:22 -0500

   EMSG_NET_LINK_UP     "%s: state change: link up, %d Mbps, %s-duplex\n"

Should indicate flow control state too.

   EMSG_NET_START_QUEUE "%s: performance event: (re)starting netdev queue\n"
   EMSG_NET_STOP_QUEUE  "%s: performance event: stopping netdev queue\n"

Oh _ABSOLUTELY NOT_, you're not printing a message
for normal events like this.  Especially those that are
going to occur on highly loaded systems.

<Prev in Thread] Current Thread [Next in Thread>