netdev
[Top] [All Lists]

Re: [PATCH] Make xfrm subsystem optional

To: "David S. Miller" <davem@xxxxxxxxxx>
Subject: Re: [PATCH] Make xfrm subsystem optional
From: Andi Kleen <ak@xxxxxxx>
Date: Sat, 14 Jun 2003 11:36:30 +0200
Cc: ak@xxxxxxx, netdev@xxxxxxxxxxx
In-reply-to: <20030614.022702.41637600.davem@xxxxxxxxxx>
References: <20030614091631.GA16993@xxxxxxxxxxxxx> <20030614.022702.41637600.davem@xxxxxxxxxx>
Sender: netdev-bounce@xxxxxxxxxxx
On Sat, Jun 14, 2003 at 02:27:02AM -0700, David S. Miller wrote:
>    From: Andi Kleen <ak@xxxxxxx>
>    Date: Sat, 14 Jun 2003 11:16:31 +0200
>    
>    This patches only compiles the xfrm subsystem in when any of the options
>    using it are selected. This shrinks the text segment on an amd64
>    kernel by ~32k, data by ~6k, bss by ~33k, overall ~72K memory saved.
> 
> I'm not going to apply this, sorry Andi.
> 
> I want the freedom to use the XFRM layer for generic things
> at some point.

But in 2.7 surely right? When what happens you can easily
make CONFIG_XFRM the default. This would give the 2.6 users
an useful option.

Also when you do use it generically you will hopefully
discard some old code (like the rt cache?) which may make
up for the additional bloat. But until that happens having
both even when not needed doesn't make too much sense.

> 
> How about working on making the xfrm layer more lean instead? :)

My last proposal for this (using hlists in the hash tables) was 
rejected, so I don't see much chance to do this.

-Andi


<Prev in Thread] Current Thread [Next in Thread>