netdev
[Top] [All Lists]

Re: [PATCH] xfrm ip6ip6 (revised)

To: mk@xxxxxxxxxxxxxx
Subject: Re: [PATCH] xfrm ip6ip6 (revised)
From: "David S. Miller" <davem@xxxxxxxxxx>
Date: Fri, 13 Jun 2003 12:07:02 -0700 (PDT)
Cc: jmorris@xxxxxxxxxxxxxxxx, kuznet@xxxxxxxxxxxxx, netdev@xxxxxxxxxxx, usagi@xxxxxxxxxxxxxx
In-reply-to: <87smqerml5.wl@xxxxxxxxxx>
References: <87fzmv5ejc.wl@xxxxxxxxxx> <20030601.013040.116362760.davem@xxxxxxxxxx> <87smqerml5.wl@xxxxxxxxxx>
Sender: netdev-bounce@xxxxxxxxxxx
   From: Mitsuru KANDA / 神田 充 <mk@xxxxxxxxxxxxxx>
   Date: Sat, 14 Jun 2003 01:03:50 +0900

        - to allocate unique spi values in xfrm6_tunnel.c  
          by using just simple open addressing hash, 

Mitsuru, what happens if two tunnels use same address?

Only first one will be found in hash, this is incorrect
behavior as it will cause the wrong SPI to be used when
packets are really destined for second user of that address.

You need to add refcount to hash table entries, so that SPI can be
shared by different xfrm6 tunnels with same address.

<Prev in Thread] Current Thread [Next in Thread>