netdev
[Top] [All Lists]

Re: [PATCH] IPV6: eliminating magic number for sizeof(struct frag_hdr)

To: yoshfuji@xxxxxxxxxxxxxx
Subject: Re: [PATCH] IPV6: eliminating magic number for sizeof(struct frag_hdr)
From: "David S. Miller" <davem@xxxxxxxxxx>
Date: Thu, 12 Jun 2003 00:54:26 -0700 (PDT)
Cc: netdev@xxxxxxxxxxx, pekkas@xxxxxxxxxx
In-reply-to: <20030612.023919.126807101.yoshfuji@xxxxxxxxxxxxxx>
References: <Pine.LNX.4.44.0306112014560.2321-100000@xxxxxxxxxx> <20030612.022753.56899094.yoshfuji@xxxxxxxxxxxxxx> <20030612.023919.126807101.yoshfuji@xxxxxxxxxxxxxx>
Sender: netdev-bounce@xxxxxxxxxxx
   From: YOSHIFUJI Hideaki / 吉藤英明 <yoshfuji@xxxxxxxxxxxxxx>
   Date: Thu, 12 Jun 2003 02:39:19 +0900 (JST)

   In article <20030612.022753.56899094.yoshfuji@xxxxxxxxxxxxxx> (at Thu, 12 
Jun 2003 02:27:53 +0900 (JST)), YOSHIFUJI Hideaki / 吉藤英明 
<yoshfuji@xxxxxxxxxxxxxx> says:
   
   > > s/8/sizeof(struct frag_hdr)/ ?
   > 
   > Yes, sizeof(struct frag_hdr). 
   > I, however, use 8 for now to focus on the bug itself.
   > (We have more "8"s there which should be substituted.)
   
   s/8/sizeof(struct frag_hdr)/;
   please apply this on top of the original patch.

I've applied both patches, thanks.

<Prev in Thread] Current Thread [Next in Thread>