netdev
[Top] [All Lists]

Re: [PATCH 2.5.70] Tun device encapsulation

To: shemminger@xxxxxxxx
Subject: Re: [PATCH 2.5.70] Tun device encapsulation
From: "David S. Miller" <davem@xxxxxxxxxx>
Date: Wed, 04 Jun 2003 23:50:05 -0700 (PDT)
Cc: acme@xxxxxxxxxxxxxxxx, jgarzik@xxxxxxxxx, akpm@xxxxxxxxx, jjs@xxxxxxxxxx, netdev@xxxxxxxxxxx
In-reply-to: <20030604154022.0ef344ff.shemminger@xxxxxxxx>
References: <20030604115236.309a173d.akpm@xxxxxxxxx> <20030604212528.GA24515@xxxxxxxxxxxxxxxx> <20030604154022.0ef344ff.shemminger@xxxxxxxx>
Sender: netdev-bounce@xxxxxxxxxxx
   From: Stephen Hemminger <shemminger@xxxxxxxx>
   Date: Wed, 4 Jun 2003 15:40:22 -0700

   Tun device was encapsulating the net_device in a private structure
   then doing:

        unregister_netdev(&tun->dev);
        kfree(tun);
        rtnl_unlock();
   
   This breaks with the delayed cleanup now in the network core.
   Moving the kfree outside of the rtnl_unlock will fix it.
   
   Builds, but not sure how to use TUN to test it.
   
This seems to indeed fix the problem for people, applied thanks.

<Prev in Thread] Current Thread [Next in Thread>