netdev
[Top] [All Lists]

Re: 2.5.70-bk+ broken networking

To: James Morris <jmorris@xxxxxxxxxxxxxxxx>
Subject: Re: 2.5.70-bk+ broken networking
From: Arnaldo Carvalho de Melo <acme@xxxxxxxxxxxxxxxx>
Date: Thu, 5 Jun 2003 00:32:08 -0300
Cc: Patrick Mansfield <patmans@xxxxxxxxxx>, Andrew Morton <akpm@xxxxxxxxx>, Stephen Hemminger <shemminger@xxxxxxxx>, Jeff Garzik <jgarzik@xxxxxxxxx>, "David S. Miller" <davem@xxxxxxxxxx>, netdev@xxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, Christoph Hellwig <hch@xxxxxxxxxxxxx>
In-reply-to: <Mutt.LNX.4.44.0306051325110.335-100000@xxxxxxxxxxxxxxxxxxxxxxxxxx>
Mail-followup-to: Arnaldo Carvalho de Melo <acme@xxxxxxxxxxxxxxxx>, James Morris <jmorris@xxxxxxxxxxxxxxxx>, Patrick Mansfield <patmans@xxxxxxxxxx>, Andrew Morton <akpm@xxxxxxxxx>, Stephen Hemminger <shemminger@xxxxxxxx>, Jeff Garzik <jgarzik@xxxxxxxxx>, "David S. Miller" <davem@xxxxxxxxxx>, netdev@xxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, Christoph Hellwig <hch@xxxxxxxxxxxxx>
Organization: Conectiva S.A.
References: <20030604184341.A10256@xxxxxxxxxxxxxxxxx> <Mutt.LNX.4.44.0306051325110.335-100000@xxxxxxxxxxxxxxxxxxxxxxxxxx>
Sender: netdev-bounce@xxxxxxxxxxx
User-agent: Mutt/1.5.4i
For the curious, it was introduced in changeset 1.1259.9.18

- Arnaldo

Em Thu, Jun 05, 2003 at 01:25:58PM +1000, James Morris escreveu:
> On Wed, 4 Jun 2003, Patrick Mansfield wrote:
> 
> > [root@elm3b79 root]# ifup eth0
> > sender address length == 0
> 
> This is a bug introduced by a coding style cleanup, fix below.
> 
> 
> - James
> -- 
> James Morris
> <jmorris@xxxxxxxxxxxxxxxx>
> 
> --- bk.pending/net/core/iovec.c       2003-06-05 11:12:59.000000000 +1000
> +++ bk.w1/net/core/iovec.c    2003-06-05 13:30:06.000000000 +1000
> @@ -47,10 +47,10 @@ int verify_iovec(struct msghdr *m, struc
>                                                 address);
>                       if (err < 0)
>                               return err;
> -                     m->msg_name = address;
> -             } else
> -                     m->msg_name = NULL;
> -     }
> +             }
> +             m->msg_name = address;
> +     } else
> +             m->msg_name = NULL;
>  
>       size = m->msg_iovlen * sizeof(struct iovec);
>       if (copy_from_user(iov, m->msg_iov, size))
> 

<Prev in Thread] Current Thread [Next in Thread>