netdev
[Top] [All Lists]

Re: 2.5.70-bk+ broken networking

To: Patrick Mansfield <patmans@xxxxxxxxxx>
Subject: Re: 2.5.70-bk+ broken networking
From: James Morris <jmorris@xxxxxxxxxxxxxxxx>
Date: Thu, 5 Jun 2003 13:25:58 +1000 (EST)
Cc: Andrew Morton <akpm@xxxxxxxxx>, Stephen Hemminger <shemminger@xxxxxxxx>, Jeff Garzik <jgarzik@xxxxxxxxx>, "David S. Miller" <davem@xxxxxxxxxx>, <netdev@xxxxxxxxxxx>, <linux-kernel@xxxxxxxxxxxxxxx>, Christoph Hellwig <hch@xxxxxxxxxxxxx>
In-reply-to: <20030604184341.A10256@xxxxxxxxxxxxxxxxx>
Sender: netdev-bounce@xxxxxxxxxxx
On Wed, 4 Jun 2003, Patrick Mansfield wrote:

> [root@elm3b79 root]# ifup eth0
> sender address length == 0

This is a bug introduced by a coding style cleanup, fix below.


- James
-- 
James Morris
<jmorris@xxxxxxxxxxxxxxxx>

--- bk.pending/net/core/iovec.c 2003-06-05 11:12:59.000000000 +1000
+++ bk.w1/net/core/iovec.c      2003-06-05 13:30:06.000000000 +1000
@@ -47,10 +47,10 @@ int verify_iovec(struct msghdr *m, struc
                                                  address);
                        if (err < 0)
                                return err;
-                       m->msg_name = address;
-               } else
-                       m->msg_name = NULL;
-       }
+               }
+               m->msg_name = address;
+       } else
+               m->msg_name = NULL;
 
        size = m->msg_iovlen * sizeof(struct iovec);
        if (copy_from_user(iov, m->msg_iov, size))


<Prev in Thread] Current Thread [Next in Thread>