Re: is sk->reuse truly a boolean?

[Arnaldo Carvalho de Melo <acme@xxxxxxxxxxxxxxxx>]

Em Wed, May 21, 2003 at 01:53:17AM +0900, YOSHIFUJI Hideaki / ?$B5HF#1QL@ 
escreveu:
> In article <20030520162906.GF801@xxxxxxxxxxxxxxxx> (at Tue, 20 May 2003 
> 13:29:07 -0300), Arnaldo Carvalho de Melo <acme@xxxxxxxxxxxxxxxx> says:
> 
> > > > In net/core/sock.c, setsockopt it just assigns 1 or 0, i.e. if userspace
> > > > passes > 1 it becomes 1, is this the intended behaviour? I think we 
> > > > have a 
> > > > bug in tcp_ipv4 or in core/sock.c 8)
> > > 
> > > Good point. However, SO_REUSEADDR works because we have 
> > > tcp_bind_conflict().
> > 
> > mmmkay, so we have to fix it by changing the test to:
> > 
> >                 if (sk->reuse)
> >                        goto success;
> > 
> > Isn't it?
> 
> I don't think so.  Above modification will break current 
> reasonable bind(2) behavior.
> 
> Well, it would be dead code, which would be used for (still 
> unsupported) SO_REUSEPORT.

So just delete the test?

- Arnaldo