netdev
[Top] [All Lists]

Re: comment about struct tcp_tw_bucket in struct sock

To: "David S. Miller" <davem@xxxxxxxxxx>
Subject: Re: comment about struct tcp_tw_bucket in struct sock
From: Andi Kleen <ak@xxxxxxx>
Date: Wed, 14 May 2003 21:21:17 +0200
Cc: ak@xxxxxxx, olh@xxxxxxx, marcelo@xxxxxxxxxxxxxxxx, netdev@xxxxxxxxxxx
In-reply-to: <20030514.121806.41651014.davem@xxxxxxxxxx>
References: <20030513210541.GA4415@xxxxxxx> <20030513.163150.28800008.davem@xxxxxxxxxx> <20030514083236.GD8290@xxxxxxxxxxxxx> <20030514.121806.41651014.davem@xxxxxxxxxx>
Sender: netdev-bounce@xxxxxxxxxxx
On Wed, May 14, 2003 at 12:18:06PM -0700, David S. Miller wrote:
>    From: Andi Kleen <ak@xxxxxxx>
>    Date: Wed, 14 May 2003 10:32:36 +0200
> 
>    On Tue, May 13, 2003 at 04:31:50PM -0700, David S. Miller wrote:
>    > It's documented in tcp.h already.
>    
>    Just not everybody changing sock.h also reads tcp.h :-(
> 
> You assume that protocols in the tree are the only thing
> that might break if you edit struct sock.

I'm not assuming anything and didn't even edit struct sock, just pointing 
out that such a fragile hack as the current tw bucket is needs an explicit 
comment on both places.

Best would be to bite the bullet and give them a common structure.

-Andi


<Prev in Thread] Current Thread [Next in Thread>