netdev
[Top] [All Lists]

comment about struct tcp_tw_bucket in struct sock

To: Marcelo Tosatti <marcelo@xxxxxxxxxxxxxxxx>, "David S. Miller" <davem@xxxxxxxxxx>
Subject: comment about struct tcp_tw_bucket in struct sock
From: Olaf Hering <olh@xxxxxxx>
Date: Tue, 13 May 2003 23:05:41 +0200
Cc: netdev@xxxxxxxxxxx
Sender: netdev-bounce@xxxxxxxxxxx
User-agent: Mutt und vi sind doch schneller als Notes
Hi,

we just hit this one. struct tcp_tw_bucket and stuct sock must match.

Please apply.



--- linux-2.4/include/net/sock.h        2003-04-24 17:11:20.000000000 +0200
+++ linux-2.4.21-rc2/include/net/sock.h 2003-05-13 23:00:32.000000000 +0200
@@ -498,6 +498,10 @@ do {       spin_lock_init(&((__sk)->lock.slock
 } while(0)
 
 struct sock {
+       /* These _must_ match the beginning of struct tcp_tw_bucket precisely.
+        * XXX Yes I know this is gross, but I'd have to edit every single
+        * XXX networking file if I created a "struct sock_header". -DaveM
+        */
        /* Socket demultiplex comparisons on incoming packets. */
        __u32                   daddr;          /* Foreign IPv4 addr            
        */
        __u32                   rcv_saddr;      /* Bound local IPv4 addr        
        */

-- 
USB is for mice, FireWire is for men!

<Prev in Thread] Current Thread [Next in Thread>