netdev
[Top] [All Lists]

Re: [PATCH] new module infrastructure for net_proto_family

To: "David S. Miller" <davem@xxxxxxxxxx>
Subject: Re: [PATCH] new module infrastructure for net_proto_family
From: Arnaldo Carvalho de Melo <acme@xxxxxxxxxxxxxxxx>
Date: Sat, 19 Apr 2003 19:57:59 -0300
Cc: netdev@xxxxxxxxxxx
In-reply-to: <20030419.151706.86912986.davem@xxxxxxxxxx>
Organization: Conectiva S.A.
References: <20030419161457.GA6164@xxxxxxxxxxxxxxxx> <20030419.151706.86912986.davem@xxxxxxxxxx>
Sender: netdev-bounce@xxxxxxxxxxx
User-agent: Mutt/1.5.4i
Em Sat, Apr 19, 2003 at 03:17:06PM -0700, David S. Miller escreveu:
>    From: Arnaldo Carvalho de Melo <acme@xxxxxxxxxxxxxxxx>
>    Date: Sat, 19 Apr 2003 13:14:57 -0300
> 
> Have a look at this:

<SNIP>
 
>    -  if (sock->ops) 
>    +  if (sock->ops) {
>               sock->ops->release(sock);
>    +          module_put(net_families[sock->ops->family]->owner);
>    +  }
 
> Maybe you want to cache sock->ops->family before calling
> sock->ops->release, maybe nobody does it but it could be
> legal to NULL sock->ops during sock->ops->release()
 
> If anything this code should NULL'ify it because any reference to sock->ops
> after the release and module_put() is a BUG() that should be trapped.

Ok, agreed, new changeset in the making.

- Arnaldo

<Prev in Thread] Current Thread [Next in Thread>