| To: | akpm@xxxxxxxxx |
|---|---|
| Subject: | Re: [2.5.66-mm3+debug] traces. |
| From: | "David S. Miller" <davem@xxxxxxxxxx> |
| Date: | Fri, 04 Apr 2003 17:35:38 -0800 (PST) |
| Cc: | netdev@xxxxxxxxxxx |
| In-reply-to: | <20030404172927.2b449167.akpm@xxxxxxxxx> |
| References: | <20030404172927.2b449167.akpm@xxxxxxxxx> |
| Sender: | netdev-bounce@xxxxxxxxxxx |
From: Andrew Morton <akpm@xxxxxxxxx> Date: Fri, 4 Apr 2003 17:29:27 -0800 It is a bit worrisome that dev_kfree_skb() is now illegal if local interrupts are disabled. I'd expect there to be more instances. Why worrisome? It's an error, and now at least we'll know about it. This isn't a "is now illegal", it's always been illegal. You simply cannot take BH locks inside of IRQ disabling ones, this is true 2.4.x too it just doesn't BUG() on you there (you get a potential deadlock instead). This patch should go through the Tulip maintainer (Jeff I guess) especially since it's a fix that belongs in 2.4.x as well. Thanks Andrew. |
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | e100: "Freeing alive device f7dd8000, eth%d", Andrew Morton |
|---|---|
| Next by Date: | Fw: [2.5.66-mm3+debug] traces., Andrew Morton |
| Previous by Thread: | Fw: [2.5.66-mm3+debug] traces., Andrew Morton |
| Next by Thread: | Re: [2.5.66-mm3+debug] traces., Andrew Morton |
| Indexes: | [Date] [Thread] [Top] [All Lists] |