netdev
[Top] [All Lists]

RE: [Fwd: [E1000] NAPI re-insertion w/ changes]

To: Robert Olsson <Robert.Olsson@xxxxxxxxxxx>
Subject: RE: [Fwd: [E1000] NAPI re-insertion w/ changes]
From: "Feldman, Scott" <scott.feldman@xxxxxxxxx>
Date: Tue, 1 Apr 2003 11:13:53 -0800
Cc: Jason Lunz <lunz@xxxxxxxxxxxx>, Jeff Garzik <jgarzik@xxxxxxxxx>, netdev@xxxxxxxxxxx
Sender: netdev-bounce@xxxxxxxxxxx
>  Also still some concern by having the watchdog kicked in e1000_intr 
>  wouldn't e1000_clean feel better? 

e1000_intr feels better to me in keeping the clean-up work separate from
managing link status change (hopefully an infrequent event :).  Do you
see any problems?
 
>  It would also be interesting to see what happens if we 
> remove the flush when enable interrupts in e1000_clean?

Ya, that read hurts, which was part of the motivation to get rid of the
disable/enables altogether.  

>  I've tested the patch that removes some of the PCI-accesses. 
> I think I sent  you some version of it. Anyway it seems to 
> have some effects. If Jason has 
>  time we will get some numbers from his instrument/setup.

Ok, let's see.

-scott

<Prev in Thread] Current Thread [Next in Thread>