[Top] [All Lists]

RE: [Fwd: [E1000] NAPI re-insertion w/ changes]

To: "Feldman, Scott" <scott.feldman@xxxxxxxxx>
Subject: RE: [Fwd: [E1000] NAPI re-insertion w/ changes]
From: Robert Olsson <Robert.Olsson@xxxxxxxxxxx>
Date: Tue, 1 Apr 2003 20:57:24 +0200
Cc: Robert Olsson <Robert.Olsson@xxxxxxxxxxx>, Jason Lunz <lunz@xxxxxxxxxxxx>, Jeff Garzik <jgarzik@xxxxxxxxx>, netdev@xxxxxxxxxxx
In-reply-to: <C6F5CF431189FA4CBAEC9E7DD5441E010107D30D@xxxxxxxxxxxxxxxxxxxxxx>
References: <C6F5CF431189FA4CBAEC9E7DD5441E010107D30D@xxxxxxxxxxxxxxxxxxxxxx>
Sender: netdev-bounce@xxxxxxxxxxx
Feldman, Scott writes:

 > Thanks for you help guys!  I broke NAPI (don't hate me) and then went on
 > vacation, so I apologize for not responding sooner.  I like what you've
 > come up with here, so I'll turn the patch around for Jeff to update 2.5
 > e1000.
 > > +       e1000_clean_tx_irq(adapter);
 > > +       e1000_clean_rx_irq(adapter, &work_done, work_to_do);
 > Just curious, why give priority to Tx over Rx?


 Honestly not too much thinking... well we can always argue by having
 Rx last we get more packets per poll. Yes we should test the other
 way around.

 Also still some concern by having the watchdog kicked in e1000_intr 
 wouldn't e1000_clean feel better? 

 It would also be interesting to see what happens if we remove the flush when 
 enable interrupts in e1000_clean?

 I've tested the patch that removes some of the PCI-accesses. I think I sent
 you some version of it. Anyway it seems to have some effects. If Jason has 
 time we will get some numbers from his instrument/setup.


<Prev in Thread] Current Thread [Next in Thread>