netdev
[Top] [All Lists]

Re: [PATCH] IPSec: IPv6 AH/ESP fixes

To: toml@xxxxxxxxxx
Subject: Re: [PATCH] IPSec: IPv6 AH/ESP fixes
From: "David S. Miller" <davem@xxxxxxxxxx>
Date: Sat, 29 Mar 2003 04:12:15 -0800 (PST)
Cc: netdev@xxxxxxxxxxx, kuznet@xxxxxxxxxxxxx
In-reply-to: <1048870457.16800.5.camel@xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx>
References: <1048870457.16800.5.camel@xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx>
Sender: netdev-bounce@xxxxxxxxxxx
   From: Tom Lendacky <toml@xxxxxxxxxx>
   Date: 28 Mar 2003 10:54:16 -0600
   
   Below is a patch for your consideration for some AH/ESP problems
   that I encountered during tunnel mode testings.
   
   Please review and let me know if any changes are required.
   
Looks good, applied.
   
One comment:

   @@ -287,7 +287,7 @@
        
        x->props.header_len = XFRM_ALIGN8(ahp->icv_trunc_len + AH_HLEN_NOICV);
        if (x->props.mode)
   -            x->props.header_len += 20;
   +            x->props.header_len += 40;
        x->data = ahp;
    
        return 0;

Yuck, let's get rid of these constants and use sizeof(ipv6_hdr) or
whatever this is supposed to me :-)

<Prev in Thread] Current Thread [Next in Thread>