| To: | "David S. Miller" <davem@xxxxxxxxxx> |
|---|---|
| Subject: | Re: skb_padto and small fragmented transmits |
| From: | Chris Leech <christopher.leech@xxxxxxxxx> |
| Date: | 06 Feb 2003 11:22:08 -0800 |
| Cc: | netdev@xxxxxxxxxxx, linux-kernel <linux-kernel@xxxxxxxxxxxxxxx> |
| In-reply-to: | <BD9B60A108C4D511AAA10002A50708F20BA2AAE3@xxxxxxxxxxxxxxxxxxxxxx> |
| Organization: | |
| References: | <BD9B60A108C4D511AAA10002A50708F20BA2AAE3@xxxxxxxxxxxxxxxxxxxxxx> |
| Sender: | netdev-bounce@xxxxxxxxxxx |
On Thu, 2003-02-06 at 10:44, David S. Miller wrote: > From: Chris Leech <christopher.leech@xxxxxxxxx> > Date: 06 Feb 2003 11:22:51 -0800 > > I fail to see how the statement "skb->len + skb->data_len" has any > usable meaning, or how it can be anything other than a bug. > > This equation is the standard way to find the full length > on any skb. For linear skbs, data_len is always zero. > > I asked Alan to use this formula so that greps on the source > tree would always show data_len being taken into account, and > thus usage would be consistent. OK, now I'm really getting confused. Every other example I can find in the networking code, and every scatter-gather capable driver, uses skb->len as the full length and skb->len - skb->data_len as the length of the first or linear portion. |
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | Re: skb_padto and small fragmented transmits, David S. Miller |
|---|---|
| Next by Date: | Re: skb_padto and small fragmented transmits, David S. Miller |
| Previous by Thread: | Re: skb_padto and small fragmented transmits, David S. Miller |
| Next by Thread: | Re: skb_padto and small fragmented transmits, David S. Miller |
| Indexes: | [Date] [Thread] [Top] [All Lists] |