[PATCH] e100 oops in 2.4.20

[Michael Rozhavsky <mrozhavsky@xxxxxxx>]

Hi,

In 2.4.20 with CONFIG_NET_CARRIER_NETLINK compiled when I'm loading e100
module I'm receiving consistent OOPS.

The reason for this is e100_update_link_state() on device init calls to
netif_carrier_on() or netif_carrier_off() while dev->carrier_task is not
initialized yet (will be initialized on register_netdev) and thus it
causes NULL pointer exception.

[<c8adbfc8>] e100_find_speed_duplex
[<c8adc46d>] e100_auto_neg
[<c8adc4bd>] e100_phy_set_speed_duplex
[<c8adc5b2>] e100_phy_set_loopback
[<c8ad6ddb>] e100_hw_init
[<c8ad6d61>] e100_init
[<c8ad62d8>] e100_found1

I'm not sure that my fix is elegant but it works for me.


--
  Michael Rozhavsky
  Senior Software Engineer
  MRV International
  Tel: +972 (4) 993-6248
  Fax: +972 (4) 989-0564
  http://www.mrv.com

e100_phy.c.diff
Description: Text document