netdev
[Top] [All Lists]

Re: eepro100 - 802.1q - mtu size

To: Jeff Garzik <jgarzik@xxxxxxxxx>
Subject: Re: eepro100 - 802.1q - mtu size
From: Ducrot Bruno <poup@xxxxxxxxxxxx>
Date: Fri, 17 Jan 2003 18:48:34 +0100
Cc: linux-kernel@xxxxxxxxxxxxxxx, netdev@xxxxxxxxxxx
In-reply-to: <20030117162818.GA1074@xxxxxxx>
References: <20030117145357.GA1139@xxxxxxxxxxxxxxxxxxx> <20030117160840.GR12676@xxxxxxxxxx> <20030117162818.GA1074@xxxxxxx>
Sender: netdev-bounce@xxxxxxxxxxx
User-agent: Mutt/1.4i
Hi Jeff,

On Fri, Jan 17, 2003 at 11:28:18AM -0500, Jeff Garzik wrote:
> On Fri, Jan 17, 2003 at 07:08:40PM +0300, Paul P Komkoff Jr wrote:
> > Replying to Florian Lohoff:
> > > Why is this patch not integerated yet ?
> > 
> > Because newer and better e100 driver, which accepts tagged frames and
> > handles it properly, already in the tree
> 
> Regardless, people still use eepro100, so I would still like to get
> eepro100 doing VLAN.
> 
> The reason why the patch was not accepted is that it changes one magic
> number to another magic number, and without chipset docs, I had no idea
> what either magic number really meant.
> 
> Now that Intel has released chipset docs, this is an excellent time to
> re-evaluate those eepro100 VLAN changes.  I still refuse to accept a
> "change the magic numbers" patch... any change will need to define
> a constant that describes the bits we wish to set/clear.
> 
> Download the e100 documentation from the e1000 sourceforge site:
> http://sourceforge.net/projects/e1000
> ["8255x Developer Manual"]
> 
>       Jeff

BTW, it look like i82557_config_cmd is never used...



--- linux-2.4/drivers/net/eepro100.c    2003/01/17 17:33:41     1.1
+++ linux-2.4/drivers/net/eepro100.c    2003/01/17 17:34:32
@@ -499,11 +499,13 @@
 /* The parameters for a CmdConfigure operation.
    There are so many options that it would be difficult to document each bit.
    We mostly use the default or recommended settings. */
+#if 0
 static const char i82557_config_cmd[CONFIG_DATA_SIZE] = {
        22, 0x08, 0, 0,  0, 0, 0x32, 0x03,  1, /* 1=Use MII  0=Use AUI */
        0, 0x2E, 0,  0x60, 0,
        0xf2, 0x48,   0, 0x40, 0xf2, 0x80,              /* 0x40=Force 
full-duplex */
        0x3f, 0x05, };
+#endif
 static const char i82558_config_cmd[CONFIG_DATA_SIZE] = {
        22, 0x08, 0, 1,  0, 0, 0x22, 0x03,  1, /* 1=Use MII  0=Use AUI */
        0, 0x2E, 0,  0x60, 0x08, 0x88,


-- 
Ducrot Bruno
http://www.poupinou.org        Page profaissionelle
http://toto.tu-me-saoules.com  Haume page


<Prev in Thread] Current Thread [Next in Thread>